Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace release script with auto shipit #828

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Replace release script with auto shipit #828

merged 14 commits into from
Oct 4, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 2, 2023 •
edited
Loading

📦 Published PR as canary version: 7.2.1--canary.828.99e7734.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@ghengeveld ghengeveld added the release Auto: Create a `latest` release when merged label Oct 2, 2023
@ghengeveld ghengeveld marked this pull request as ready for review October 2, 2023 14:34
@ghengeveld ghengeveld removed the release Auto: Create a `latest` release when merged label Oct 2, 2023
@ghengeveld ghengeveld requested a review from tmeasday October 2, 2023 19:13
thafryer
thafryer approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tmeasday
tmeasday reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the action part -- looks like it published this PR to v1?

https://github.com/chromaui/chromatic-cli/actions/runs/6397978376/job/17367105473?pr=828

@ghengeveld
Copy link
Member Author

Looks good apart from the action part -- looks like it published this PR to v1?

chromaui/chromatic-cli/actions/runs/6397978376/job/17367105473?pr=828

v1 is the tag we use right now, always. It's the one that's linked to our Marketplace release.

I'm punting on the other (semver) tags for now. Let's get this operational before we make any actual changes to the final release. As implemented it's the same as it was before.

@ghengeveld ghengeveld merged commit ad80661 into main Oct 4, 2023
@ghengeveld ghengeveld deleted the auto-release branch October 4, 2023 12:57
@tmeasday
Copy link
Member

tmeasday commented Oct 4, 2023

@ghengeveld but that means every PR will get pushed to v1 right now.

@ghengeveld
Copy link
Member Author

@tmeasday For action-canary, yes. Perhaps we shouldn't auto-release that one but only do manual releases. I'll update that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday left review comments

@thafryer thafryer thafryer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghengeveld @tmeasday @thafryer