Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --local flag and pass to builds as isLocalBuild #795

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Aug 8, 2023

I'm not sure if we want the flag (it could just be a node API option), but I thought it could be helpful for debugging. I didn't add it as an input to the action. Not sure if that's confusing.

Depends on https://github.com/chromaui/chromatic/pull/7576

@tmeasday tmeasday requested a review from ghengeveld August 8, 2023 07:32
@linear
Copy link

linear bot commented Aug 8, 2023

AP-3462 Mark addon-initiated builds as local

Add a option/flag to the CLI for "local" build, which is always set by addon-initiated builds.

Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks but otherwise LGTM.

node-src/lib/parseArgs.ts Outdated Show resolved Hide resolved
node-src/lib/parseArgs.ts Outdated Show resolved Hide resolved
@tmeasday
Copy link
Member Author

tmeasday commented Aug 9, 2023

@ghengeveld as discussed on Slack we dropped the --local option and now the only way to get a local build is to use the node API. We can revisit this later if we like.

@tmeasday tmeasday merged commit 85e34f2 into main Aug 21, 2023
@tmeasday tmeasday deleted the tom/ap-3462-mark-addon-initiated-builds-as-local branch August 21, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants