update getStorybookMetadata to safely record version even if fails to parse mainConfig

[JonathanKolnik]

Even though we reproduced, tested, and fixed a mainConfig parsing bug, it is possible that certain formats are still not readable. In that event we want to at least still record the metadata that we can gather.

[linear]

AP-2756 Chromatic telemetry reports `null` `storybook_version`

How is the user affected?

Our telemetry reports storybook_version = null for a large proportion of our build events:

image.png

How many and/or what class of users does this impact?

Unsure, possible all users, or maybe a specific CLI version / SB version

Is there a workaround?

Backfill data based on other data.

What are the steps for reproducing the issue?

Not sure.

Other information

Run this query to see the above data (run on Jan 18):

SELECT count(*) as count, storybook_version FROM `warehouse-production-209019.chromatic_webapp2.create_ci_build_view`
WHERE extract(year from timestamp) = 2023
GROUP BY storybook_version
ORDER BY count DESC

[tmeasday]

OK, LGTM. @zol @thafryer this will mean that in some proportion of cases (it looks like maybe as many as 1/3) where we fail to parse main.js, we report the SB + CH versions correctly, but we won't have a valid addons list or builder (they'll be "unknown").

In order to investigate further we'll probably need to start uploading the errors we are getting trying to parse the file. That's a bit tricky because we need to sanitize the errors etc. We should consider if we want the data enough to do that.

[thafryer]

LGTM. Tests are failing. It's likely because of the tweak to catch block.

[thafryer]

LGTM. Tests are failing. It's likely because of the tweak to catch block.