Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various counts as GitHub Action outputs #620

Merged
merged 4 commits into from
Sep 17, 2022

Conversation

SiTaggart
Copy link
Contributor

Add the changeCount from the current Chromatic build to the output from the GitHub action.

@ndelangen
Copy link
Member

@ghengeveld WDTY about this?
1 problem I see is that this will likely not won't work when the --exit-once-uploaded is set.

@thafryer thafryer requested a review from ghengeveld August 5, 2022 14:50
@SiTaggart
Copy link
Contributor Author

Any movement on this? We'd love to have this unblock a workflow for us @ndelangen @ghengeveld

@ghengeveld
Copy link
Member

I added a bunch of other counts as well. Good stuff 👍

@ghengeveld ghengeveld changed the title feat: add changeCount to gh action output Add various counts as GitHub Action outputs Sep 1, 2022
@SiTaggart
Copy link
Contributor Author

Hi @ghengeveld @ndelangen

Do you have an ETA on when this will merge and get released to the CLI and Github Action?

Thanks

@ndelangen
Copy link
Member

@ghengeveld I think we should just merge and release this. Do you know of anything blocking this?

@ghengeveld ghengeveld merged commit 2371b81 into chromaui:main Sep 17, 2022
@SiTaggart SiTaggart deleted the feat/add-changecount branch September 21, 2022 20:31
@ghengeveld
Copy link
Member

@SiTaggart in case you didn't know already, these fields should all be available now.

@SiTaggart
Copy link
Contributor Author

Yeah, this is amazing. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants