Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle redirects when using --storybook-url #596

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Handle redirects when using --storybook-url #596

merged 3 commits into from
Jun 27, 2022

Conversation

ghengeveld
Copy link
Member

Rather than just assuming iframe.html will exist where we expect it to be, actually resolve the provided URL and add iframe.html to the resolved (redirected) URL.

@ghengeveld ghengeveld requested a review from kylegach June 24, 2022 11:55
@linear
Copy link

linear bot commented Jun 24, 2022

DX-237 British Gas components link to a broken url

Repro:

  1. Go here https://storybook.js.org/showcase/british-gas-nucleus
  2. Click on "Storybook" to see the Storybook is still there
  3. Click on a component in the list to get an error page

I think it's because the component URL is missing index.html

@ghengeveld ghengeveld changed the title Add support for redirects with --storybook-url Handle redirects with --storybook-url Jun 24, 2022
@ghengeveld ghengeveld changed the title Handle redirects with --storybook-url Handle redirects when using --storybook-url Jun 24, 2022
@ghengeveld ghengeveld requested a review from tmeasday June 24, 2022 12:49
tmeasday
tmeasday approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM!

bin-src/lib/startStorybook.ts Show resolved Hide resolved
@ghengeveld ghengeveld merged commit 4dcfad3 into main Jun 27, 2022
@ghengeveld ghengeveld deleted the ghengeveld/dx-237-british-gas-components-link-to-a-broken branch June 27, 2022 11:49
@ghengeveld
Copy link
Member Author

Released in 6.6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@kylegach kylegach Awaiting requested review from kylegach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @tmeasday