-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement async build creation process #562
Implement async build creation process #562
Conversation
CH-1759 Update CLI to use new build creation API
Introduce new "initialize build" step. Deal with partial build data. Drop "retryable" build mechanism. |
2886b53
to
ac199d3
Compare
Published as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great!
I'm calling this done but holding off the merge until we ship the backend changes. |
@ghengeveld I tested this on a git repo with no origin setup and it errored with:
|
Opened a PR to address this here: https://github.com/chromaui/chromatic/pull/6162 |
This updates the CLI to use the new three-step build creation process:
announceBuild
➡️publishBuild
➡️verifyBuild
Also this adds
mergeCommit
to the build info.Relies on https://github.com/chromaui/chromatic/pull/6005
and https://github.com/chromaui/chromatic/pull/6162