Add TurboSnap support for Vite #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do that in the vite rollup plugin, instead
IanVS
commented
Feb 14, 2022
|
I've been running turbosnap on my own repo with these (and other) changes |
IanVS
added a commit
to storybookjs/builder-vite
that referenced
this pull request
Feb 18, 2022
I'm working on enabling Chromatic [Turbosnap](https://www.chromatic.com/docs/turbosnap) capability for vite storybook projects, and it requires a small change to the way we load in our stories to match up more closely to how the webpack builders work. They have a separate entrypoint for just the stories, so I've moved what used to be done in the virtual `storybook-stories.js` imported directly off of the iframe, into a virtual file that's imported from the virtual `vite-app` module. This actually more closely aligns with the way that the "modern" (storyStoreV7) code works too, which is a nice side-benefit. I also needed to move the preview entry to it's own file, for the same reason. I didn't move anything in the storyStoreV7 version, mostly because I'm not using storyStoreV7, and don't have a great way to test out that it's working correctly if I do muck with it. For now I'd like to take things one step at a time and support turbosnap for non-storyStoreV7 builds. I've used `patch-package` to run this code in my own storybook at work to ensure that turbosnap works the way I am intending. So far it seems to be working well. Here is the corresponding PR in chromatic-cli to enable vite support: chromaui/chromatic-cli#521.
ghengeveld
approved these changes
Feb 19, 2022
ghengeveld
changed the title
|
Hey @IanVS thank you so much for all of your efforts! As always the work you've been doing is incredible and we're incredibly thankful for each and every contribution you make! Thanks for helping Storybook and its ecosystem thrive! |
|
Released in 6.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on a mission to use turbosnap in my own project, which is built using storybook-builder-vite. It's going to take a few different pieces:
preview-stats.jsonfrom webpack.