Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requirement for the token #465

Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Dec 7, 2021

Remove the need to set a GitHub token

@ndelangen ndelangen self-assigned this Dec 7, 2021
@linear
Copy link

linear bot commented Dec 7, 2021

CH-1052 GITHUB_TOKEN is possibly not necessary anymore

💬Talk to a developer

Hi, I am setting up a github action for chromatic and I see you ask to send a github token:
```
token: ${{ secrets.GITHUB_TOKEN }}
```

But in the source code I can't see where that is used: https://github.com/chromaui/chromatic-cli/blob/next/action-src/main.ts

I do see it used to be used 2 years ago (I didn't check exactly when the line getInput('token') was removed). Could it be that it's not needed anymore? Can I safely remove it, and if so can you remove it from the docs too? Thanks!

@ndelangen ndelangen merged commit 5fa236c into main Dec 8, 2021
@ndelangen ndelangen deleted the norbert/ch-1052-github_token-is-possibly-not-necessary branch December 8, 2021 09:46
rosslannen pushed a commit to lucimobility/foxglove-studio that referenced this pull request Jul 12, 2023
**User-Facing Changes**
None

**Description**
This is no longer needed as of
chromaui/chromatic-cli#465 (credit to
@ethriel3695 for finding the relevant PR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant