Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Turbosnap metrics logs #1142

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Remove Turbosnap metrics logs #1142

merged 1 commit into from
Jan 16, 2025

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Jan 16, 2025 •
edited by chromatic-ci-bot
Loading

Now that we have solid numbers from our metric logging, we can revoke the token and remove the logging code.

📦 Published PR as canary version: 11.26.0--canary.1142.12814710545.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup
Revert "Merge pull request #1141 from chromaui/cody/cap-2635-add-metr…
6646a43 
…ics-to-determine-if-lock-file-parsing-is-helping-or"

This reverts commit f349c8e, reversing
changes made to 1ecc76c.
@codykaup codykaup self-assigned this Jan 16, 2025
@codykaup codykaup added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

📦 Package Size: 5448 KB

@codykaup codykaup requested a review from a team January 16, 2025 15:38
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.44%. Comparing base (f349c8e) to head (6646a43).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
- Coverage   69.53%   69.44%   -0.09%     
==========================================
  Files         203      202       -1     
  Lines        7369     7335      -34     
  Branches     1286     1284       -2     
==========================================
- Hits         5124     5094      -30     
+ Misses       2222     2218       -4     
  Partials       23       23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codykaup codykaup added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit f5cdcfb Jan 16, 2025
23 of 26 checks passed
@codykaup codykaup deleted the cody/cap-2650-remove-metric-logging branch January 16, 2025 17:51
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.25.0 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhobbs jmhobbs jmhobbs approved these changes

Assignees

@codykaup codykaup

Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codykaup @chromatic-ci-bot @jmhobbs