-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip lock file parsing if it's larger than 10MB #1140
Skip lock file parsing if it's larger than 10MB #1140
Conversation
📦 Package Size: 5448 KB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
+ Coverage 69.39% 69.44% +0.05%
==========================================
Files 202 202
Lines 7322 7335 +13
Branches 1280 1284 +4
==========================================
+ Hits 5081 5094 +13
Misses 2218 2218
Partials 23 23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @codykaup !
@codykaup One question on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we want to expose this via environment variable as well, in case it's running on smaller CI boxes and still OOM's at 10MB?
@ethriel3695 that's a separate ticket. I wanted to fix the issue quickly then follow it up with monitoring. Good callout though!
Yeah probably. I'll toss that in here. |
🚀 PR was released in |
We've been seeing some OOM errors in TurboSnap that appears to come from our lock file parser. This attempts to alleviate that issue by completely skipping the lock file parsing if it's larger than 10 MB so we still get some of the benefits of TurboSnap without completely disabling it.
In case it wasn't obvious, the 10MB limit is a guess. We can adjust it as needed.
📦 Published PR as canary version:
11.24.0--canary.1140.12756027021.0
✨ Test out this PR locally via: