Fix --diagnostics-file parsing

[codykaup]

I would appear if you pass anything to --diagnostics-file, it doesn't do anything and just writes to the default location.

This happens because

1. We're using defaultIfSet instead of defaultUnlessSetOrFalse when parsing that option
2. Our || operation was actually getting parsed as:

(defaultIfSet(flags.diagnosticsFile, DEFAULT_DIAGNOSTICS_FILE) || flags.diagnostics)
        ? DEFAULT_DIAGNOSTICS_FILE
        : undefined,

So if you set --diagnostics-file or --diagnostics, we'll always use the default file location.

📦 Published PR as canary version: 11.16.5--canary.1116.11667959497.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

[github-actions]

📦 Package Size: 5380 KB
✅ Compared to main: 0 KB db3848b (5380 KB)

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.01% (target: -1.00%)	✅ 100.00% (target: 80.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (db3848b)	7116	4839	68.00%
Head commit (d66dee9)	7114 (-2)	4838 (-1)	68.01% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1116)	2	2	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[chromatic-ci-bot]

🚀 PR was released in v11.16.4 🚀