-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update task output to account for E2E #1096
Update task output to account for E2E #1096
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
📦 Package Size: 5380 KB |
3f921dd
to
ac99304
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question in there.
a85ce03
to
4f021fc
Compare
Some of our imports can error in Storybook so moving this util function out makes sense.
4f021fc
to
035243b
Compare
🚀 PR was released in |
When using our E2E integration (Playwright or Cypress), it can be rather confusing to see "Storybook" and "stories" everywhere. This changes those to reference "Test suite" and "tests" through the UI.
The biggest change I had to make for this was to pass the main
Context
around to set the task title and output based on if it's an E2E build or not.📦 Published PR as canary version:
11.15.0--canary.1096.11448539011.0
✨ Test out this PR locally via: