Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task output to account for E2E #1096

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Oct 16, 2024

When using our E2E integration (Playwright or Cypress), it can be rather confusing to see "Storybook" and "stories" everywhere. This changes those to reference "Test suite" and "tests" through the UI.

The biggest change I had to make for this was to pass the main Context around to set the task title and output based on if it's an E2E build or not.

📦 Published PR as canary version: 11.15.0--canary.1096.11448539011.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Oct 16, 2024
@codykaup codykaup self-assigned this Oct 16, 2024
Copy link

codacy-production bot commented Oct 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+12.36% (target: -1.00%) 84.23% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fd1359f) 8540 4677 54.77%
Head commit (035243b) 7057 (-1483) 4737 (+60) 67.12% (+12.36%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1096) 298 251 84.23%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup marked this pull request as draft October 16, 2024 21:05
Copy link
Contributor

github-actions bot commented Oct 16, 2024

📦 Package Size: 5380 KB
⚠️ Compared to main: +4 KB fd1359f (5376 KB)

@codykaup codykaup force-pushed the cody/cap-2206-copy-update-cli-output-for-playwright-and-cypress-runs branch 2 times, most recently from 3f921dd to ac99304 Compare October 16, 2024 21:45
@codykaup codykaup requested a review from a team October 16, 2024 22:23
@codykaup codykaup marked this pull request as ready for review October 16, 2024 22:24
Copy link
Contributor

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question in there.

node-src/ui/tasks/storybookInfo.ts Outdated Show resolved Hide resolved
@codykaup codykaup force-pushed the cody/cap-2206-copy-update-cli-output-for-playwright-and-cypress-runs branch 4 times, most recently from a85ce03 to 4f021fc Compare October 18, 2024 20:07
@codykaup codykaup force-pushed the cody/cap-2206-copy-update-cli-output-for-playwright-and-cypress-runs branch from 4f021fc to 035243b Compare October 21, 2024 20:26
@codykaup codykaup added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit eb3a695 Oct 21, 2024
20 of 21 checks passed
@codykaup codykaup deleted the cody/cap-2206-copy-update-cli-output-for-playwright-and-cypress-runs branch October 21, 2024 20:58
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.14.0 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants