-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLI version output #1079
Fix CLI version output #1079
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
📦 Package Size: 5268 KB |
3ec7343
to
035c9b7
Compare
035c9b7
to
0542e1f
Compare
This fixes a couple issues around versioning in our CLI output.
--version
shows the project'spackage.json
version and not the CLI versionIncorrect version information on build
This one stems from a timing issue between
auto shipit
and our build process. We actually build the CLI before we callauto shipit
(which is whatauto
recommends). However,auto
figures out what the version will be during it's deployment step. Therefore, we need toauto shipit --dry-run
to get the latest version without deployingpackage.json
auto shipit
againIncorrect version from
--version
We use meow for our CLI flags and it tries to figure out the version for you, if it's not set. Therefore, calling
npx chromatic --version
will just print the version in your project instead of the CLI version. Simply setting this value when building fixes that issue!📦 Published PR as canary version:
11.11.1--canary.1079.11182593192.0
✨ Test out this PR locally via: