Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript config from internal repo and fix some errors #1070

Merged

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Oct 1, 2024

This adds most of the tsconfig.json from our internal repo with one exception: strict: true. Therefore, this is mostly fixing random errors that appear when enabling strict mode. There were 273 errors in 60 files when I first turned this on. I fixed a little more than half with this PR and figured that was a good place to stop. Unfortunately, there's 109 errors in 32 files remaining after this.

Note: I focused on errors that should have zero impact on the flow of the CLI. There are some other changes we'll have to make that are a bit riskier so I left those for future me.

📦 Published PR as canary version: 11.11.1--canary.1070.11150810838.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Oct 1, 2024
@codykaup codykaup self-assigned this Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

📦 Package Size: 4644 KB
⚠️ Compared to main: +4 KB ab380a0 (4640 KB)

@codykaup codykaup force-pushed the cody/cap-2188-add-typescript-config-from-capture-cloud branch 2 times, most recently from 065ce6e to 2892fba Compare October 1, 2024 22:29
Copy link

codacy-production bot commented Oct 1, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.08% (target: -1.00%) 59.02% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ab380a0) 8460 4557 53.87%
Head commit (54311d9) 8485 (+25) 4564 (+7) 53.79% (-0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1070) 122 72 59.02%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup requested a review from a team October 1, 2024 22:33
node-src/tasks/build.ts Outdated Show resolved Hide resolved
node-src/tasks/upload.ts Outdated Show resolved Hide resolved
node-src/ui/messages/info/storybookPublished.ts Outdated Show resolved Hide resolved
@codykaup codykaup force-pushed the cody/cap-2188-add-typescript-config-from-capture-cloud branch from d93a437 to 3a319ca Compare October 2, 2024 19:51
@codykaup codykaup force-pushed the cody/cap-2188-add-typescript-config-from-capture-cloud branch from 3a319ca to 54311d9 Compare October 2, 2024 20:05
@codykaup codykaup requested a review from jmhobbs October 2, 2024 20:09
@codykaup codykaup added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 2be66ae Oct 2, 2024
20 of 21 checks passed
@codykaup codykaup deleted the cody/cap-2188-add-typescript-config-from-capture-cloud branch October 2, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants