-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript config from internal repo and fix some errors #1070
Add TypeScript config from internal repo and fix some errors #1070
Conversation
📦 Package Size: 4644 KB |
065ce6e
to
2892fba
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
d93a437
to
3a319ca
Compare
3a319ca
to
54311d9
Compare
This adds most of the
tsconfig.json
from our internal repo with one exception:strict: true
. Therefore, this is mostly fixing random errors that appear when enabling strict mode. There were 273 errors in 60 files when I first turned this on. I fixed a little more than half with this PR and figured that was a good place to stop. Unfortunately, there's 109 errors in 32 files remaining after this.Note: I focused on errors that should have zero impact on the flow of the CLI. There are some other changes we'll have to make that are a bit riskier so I left those for future me.
📦 Published PR as canary version:
11.11.1--canary.1070.11150810838.0
✨ Test out this PR locally via: