Include storybookUrl
and webUrl
on skipped rebuild
#1060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1053
In our FAQ section, we point out that customers can pull
storybookUrl
andwebUrl
from thechromatic-diagnostics.json
file. Source: https://www.chromatic.com/docs/faq/get-published-storybook-url-via-ci/However, this field isn't being set when a rebuild is found. To keep things easy on our customers, this adds those fields back in.
Note: Turns out, we don't have documented output for our diagnostics because it's more of an internal debugging file. However, I opted to add a new field for
rebuildForBuild
with the details in case any customers were relying onbuild
for something.📦 Published PR as canary version:
11.11.0--canary.1060.11077751294.0
✨ Test out this PR locally via: