Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include storybookUrl and webUrl on skipped rebuild #1060

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 27, 2024

Closes #1053

In our FAQ section, we point out that customers can pull storybookUrl and webUrl from the chromatic-diagnostics.json file. Source: https://www.chromatic.com/docs/faq/get-published-storybook-url-via-ci/

However, this field isn't being set when a rebuild is found. To keep things easy on our customers, this adds those fields back in.

Note: Turns out, we don't have documented output for our diagnostics because it's more of an internal debugging file. However, I opted to add a new field for rebuildForBuild with the details in case any customers were relying on build for something.

📦 Published PR as canary version: 11.11.0--canary.1060.11077751294.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@codykaup codykaup added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Sep 27, 2024
@codykaup codykaup self-assigned this Sep 27, 2024
Copy link
Contributor

📦 Package Size: 4180 KB
✅ Compared to main: 0 KB 38a7b49 (4180 KB)

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.27% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (38a7b49) 8348 4485 53.73%
Head commit (cb887f1) 8350 (+2) 4509 (+24) 54.00% (+0.27%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1060) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup requested a review from a team September 27, 2024 21:13
@codykaup codykaup added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 055ebd3 Sep 30, 2024
25 of 26 checks passed
@codykaup codykaup deleted the 1053-chromatic-diagnosticsjson-no-longer-includes-`storybookUrl`-or-`webUrl` branch September 30, 2024 20:24
@ghengeveld
Copy link
Member

🚀 PR was released in v11.11.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chromatic-diagnostics.json no longer includes storybookUrl or webUrl
3 participants