Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the --flag=value format for Storybook build options #1034

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Sep 10, 2024

This format is better supported by CLI wrappers (e.g. Angular) and prevents build errors.

📦 Published PR as canary version: 11.9.1--canary.1034.10818998303.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@jmhobbs jmhobbs added bug Classification: Something isn't working release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Sep 10, 2024
@jmhobbs jmhobbs requested review from tevanoff and a team September 10, 2024 17:43
@jmhobbs jmhobbs self-assigned this Sep 10, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5f0500f1 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5f0500f) Report Missing Report Missing Report Missing
Head commit (f4a2de0) 8471 6690 78.98%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1034) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@codykaup codykaup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tevanoff tevanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jmhobbs jmhobbs added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit b9ccb27 Sep 11, 2024
29 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2100-fix-cli-flag-syntax-in-github-action branch September 11, 2024 20:13
@ghengeveld
Copy link
Member

🚀 PR was released in v11.9.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants