Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback type for Storybook 6 builder syntax #1001

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

ethriel3695
Copy link
Contributor

@ethriel3695 ethriel3695 commented Jun 3, 2024

There is a builder check in the storybook metadata, and SB 6 uses an object for the builder rather than the new format of a string value.

We added logic to handle both.

📦 Published PR as canary version: 11.5.1--canary.1001.9355178223.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

Copy link

codacy-production bot commented Jun 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 80.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9ca67a5) 8450 6667 78.90%
Head commit (9483a03) 8449 (-1) 6668 (+1) 78.92% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1001) 10 8 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Jun 3, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Jun 3, 2024
@ghengeveld ghengeveld removed this pull request from the merge queue due to a manual request Jun 3, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Jun 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 3, 2024
Add fallback type for Storybook 6 builder syntax
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2024
@ethriel3695 ethriel3695 requested a review from thafryer June 3, 2024 17:51
@ghengeveld ghengeveld added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 8c814b2 Jun 3, 2024
22 checks passed
@ghengeveld ghengeveld deleted the reuben/fix-sb-6-errors branch June 3, 2024 19:10
@ghengeveld
Copy link
Member

🚀 PR was released in v11.5.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants