Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromatic Demo flow fails to work with the CLI #398

Closed
dudulasry opened this issue Sep 11, 2021 · 3 comments
Closed

Chromatic Demo flow fails to work with the CLI #398

dudulasry opened this issue Sep 11, 2021 · 3 comments
Assignees
Labels
question Tracking: Further information is requested

Comments

@dudulasry
Copy link

Hey everyone,

I just installed chromatic in my project and started the tutorial of Chromatic. However, when I get to the point where I need to make some change in the UI and publish again, the CLI fails to do that.

This is the error I got:

✖ Found 1 visual change: failing with exit code 1
Pass --exit-zero-on-changes to succeed this command regardless of changes.
Pass --auto-accept-changes to succeed and automatically accept any changes.
ℹ Review the changes at https://www.chromatic.com/build?appId=613a7735df6708003ac5c227&number=6

I added the flag --exit-zero-on-changes in order to continue the tutorial. I think the tutorial should be updated

@tmeasday tmeasday added the question Tracking: Further information is requested label Sep 16, 2021
@domyen
Copy link
Member

domyen commented Sep 16, 2021

@dudulasry thanks for reporting this. I'm looking into it. Do you mind linking me to the tutorial you referenced (for example, on the Chromatic website, Storybook site, or elsewhere)?

@dudulasry
Copy link
Author

@domyen It's the first tutorial someone sees when creating a new project in Chromatic. I'm not sure how to link to it 🧐

@domyen
Copy link
Member

domyen commented Sep 16, 2021

Hey Dudu, I just ran through the onboarding myself. The message you're seeing is intentional and you completed the workflow successfully.

✖ Found 18 visual changes: failing with exit code 1
Pass --exit-zero-on-changes to succeed this command regardless of changes.
Pass --auto-accept-changes to succeed and automatically accept any changes.

"Failing with exit-code 1" message is for folks that are setting up CI. I can see how it'd be confusing at this stage in the process. Will chat with the team here about tweaking this messaging.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Tracking: Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants