Clear storyStatus when no longer relevant

[ndelangen]

What I did:

• clear storyStatus when we get partial buildData
• clear storyStatus when there is no build

📦 Published PR as canary version: 0.0.53--canary.65.575bce7.0

✨ Test out this PR locally via:

npm install @chromaui/[email protected]
# or 
yarn add @chromaui/[email protected]

[tmeasday]

LGTM. Is it possible to do some assertion a play function that we call the right version of updateStatus at the right time in the a VisualTests story?

[tmeasday]

Great job on the tests ✅ I have a couple questions before we merge this though

[ndelangen]

@gert the custom render method is easier way to override the arg.
You suggested adding a arg with a _ prefix, remember? I think this is a much much cleaner solution.

In fact the _ prefix method didn't work, this one does.

EDIT: never mind, the suggestion by @tmeasday worked.

[ndelangen]

Scrap that, that solution doesn't work... @tmeasday

Do you have suggestions that would fix the problem then, considering you do not like the custom render solution.

[tmeasday]

@ndelangen let me try

[tmeasday]

@ndelangen this approach works although has some typing issues that may be resolvable:

  args: {
    updateBuildStatus: action("updateBuildStatus"),
  },
  play: async ({ args }) => {
    await waitFor(() => {
      expect(args.updateBuildStatus).toHaveBeenCalled();
      const fn = args.updateBuildStatus.mock.calls[0][0];
      expect(fn({})).toEqual({});
    });
  },

WDYT?

[ndelangen]

I think the custom render approach is a simpler approach @tmeasday and has no type issues..

That proposal has type issues on both the args and play function side.
action doesn't the type of the arg.
If I force it than the args that the play function receives won't match the jest mock..

I could force both.. but why?
A customer render function solves it, without any type casting. It's AFAICS far more type-safe / type-correct.