Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selectedTest whenever tests change (e.g. when switching stories) #51

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Aug 25, 2023

📦 Published PR as canary version: 0.0.38--canary.51.2b3e92b.0

✨ Test out this PR locally via:

npm install @chromaui/[email protected]
# or 
yarn add @chromaui/[email protected]

@ghengeveld ghengeveld requested a review from tmeasday August 25, 2023 08:35
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense but I reckon we could have some tests for the behaviour

@ghengeveld
Copy link
Member Author

I dropped the unit tests in favor of stories that cover the functionality provided by useTests, and verify that switching browser/viewport/tests works properly.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ghengeveld ghengeveld merged commit d4cefc9 into main Aug 26, 2023
@ghengeveld ghengeveld deleted the ghengeveld/ap-3567-snapshot-image-doesnt-change-when-you-switch-stories branch August 26, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants