Allow interacting with Storybook UI through the Joyride overlay #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
added
skip-release
|
Can you give some context in which particular scenarios the user must interact with the page? As I understood, it is just about scrolling to the spotlight area. Should we do this programmatically instead? I am concerned that allowing to navigate on the page by the user will introduce more uncommon behavior. I would really love to prevent this and figure out a way for spotlights to always be in the viewport. |
ghengeveld
force-pushed
the
ghengeveld/232-when-there-are-multiple-connected-storybooks-the
branch
from
f906629 to
6ba7f68
Compare
|
Closing in favor of #307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Joyride (guided tour) overlay normally prevents the user from interacting with the underlying page. However, it's possible for the "spotlight" area (which can be interacted with) to be positioned outside the viewport. When this happens it's impossible to continue or skip the tour since the entire screen is locked. By disabling user events on the overlay, it becomes possible to interact with the content below, including scrolling the sidebar. This is the simplest fix and while it's a little weird to be able to use Storybook with an overlay on top, I think that's a reasonable tradeoff.
Screen.Recording.2024-05-13.at.22.19.42.mov
It's a little weird that the overlay removes itself while scrolling, unfortunately I didn't find a way to prevent that.