Support builds from (supposed) forked repository or monorepo setup #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
added
release
ghengeveld
added
skip-release
ghengeveld
deleted the
ghengeveld/290-hit-error-waiting-for-build-on-master
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the owner name of the local Git repository doesn't match that of the repository linked to the Chromatic project, local builds will have branch names prefixed with the local owner name (to indicate that the build originates from a fork).
When selecting a build in the VTA, this owner name prefix isn't taken into account, causing the VTA to hang while it looks for a build matching the local Git branch. This PR addresses this mismatch by disregarding the potential owner name prefix. This is safe to do because the BuildQuery already filters by owner name, so we needn't check it again.
Fixes #290