Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "run tests" button and other UI issues #199

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Fix "run tests" button and other UI issues #199

merged 8 commits into from
Mar 7, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Mar 6, 2024 •
edited by tmeasday
Loading

  • Hides or disables the "run tests" button when running, whatever is appropriate.
  • Hides the "Latest snapshot" label when no controls are available, making the whole upper section collapse when there is no need for it.
  • Adds a "Code edits detected" message.
  • Avoids passing down startDevBuild function, instead using a context provider.
📦 Published PR as canary version: 1.2.9--canary.199.3e82055.0

✨ Test out this PR locally via:

npm install @chromatic-com/[email protected]
# or 
yarn add @chromatic-com/[email protected]

andrewortwein
andrewortwein previously requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but I think we should add a few stories to capture the improvements you made. Please let me know if they're already there and I just missed them.

@thafryer thafryer requested a review from andrewortwein March 7, 2024 20:22
thafryer
thafryer approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghengeveld ghengeveld merged commit d0ea271 into main Mar 7, 2024
5 checks passed
@ghengeveld ghengeveld deleted the ghengeveld/ap-4138-play-button-in-addon-panel-ux branch March 7, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thafryer thafryer thafryer approved these changes

@andrewortwein andrewortwein Awaiting requested review from andrewortwein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghengeveld @andrewortwein @thafryer