Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Fast Follows #172

Merged
merged 9 commits into from
Feb 6, 2024
Merged

QA Fast Follows #172

merged 9 commits into from
Feb 6, 2024

Conversation

thafryer
Copy link
Member

@thafryer thafryer commented Feb 2, 2024

Fixes AP-4093, AP-4088, AP-4129, AP-4130, AP-4135, AP-4189

This PR seeks to resolve issues resulting from QA and feedback.

  1. AP-4088, AP-4135, AP-4189 - At this point, the user is no longer required to set an origin. They still need to initialize the Git repo and commit at least one.
  2. AP-4093 - If a user runs a project in a repo that does not have a chromatic script in their package.json, this interactive prompt will no longer appear in the CLI console.
  3. AP-4129 - This adds a link to the user's Chromatic project in the footer menu of the addon. If there is no project set, we send them to https://www.chromatic.com/start, which will redirect them to their last visited account or to log in.
  4. AP-4130, AP-4189 - This adds an option to remove the addon via the footer menu and from the "Git Not Detected" Screen.
📦 Published PR as canary version: 1.0.5--canary.172.9d48858.0

✨ Test out this PR locally via:

npm install @chromatic-com/[email protected]
# or 
yarn add @chromatic-com/[email protected]

@thafryer thafryer force-pushed the qa-fast-follows branch 2 times, most recently from 95c7a87 to d32d3a2 Compare February 2, 2024 05:20
@thafryer thafryer force-pushed the qa-fast-follows branch 4 times, most recently from f1610e4 to 4e18bec Compare February 3, 2024 03:08
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise. I think the Panel component is getting a bit messy now, perhaps there's some simple things we can do to clean it up a bit.

src/Panel.tsx Outdated Show resolved Hide resolved
.storybook/preview.tsx Show resolved Hide resolved
@tmeasday
Copy link
Member

tmeasday commented Feb 4, 2024

@thafryer

AP-4088, AP-4135, AP-4189 - At this point, the user is no longer required to set an origin. They still need to initialize the Git repo and commit at least one.
AP-4093 - If a user runs a project in a repo that does not have a chromatic script in their package.json, this interactive prompt will no longer appear in the CLI console.

Are these two changes in the CLI? Are they part of this PR just via bumping the version?

In general, it would be better to have multiple PRs if different things are happening, IMO.

@thafryer
Copy link
Member Author

thafryer commented Feb 5, 2024

@thafryer

AP-4088, AP-4135, AP-4189 - At this point, the user is no longer required to set an origin. They still need to initialize the Git repo and commit at least one.
AP-4093 - If a user runs a project in a repo that does not have a chromatic script in their package.json, this interactive prompt will no longer appear in the CLI console.

Are these two changes in the CLI? Are they part of this PR just via bumping the version?

In general, it would be better to have multiple PRs if different things are happening, IMO.

Yes! AP-4088, AP-4135, and AP-4189 are resolved by bumping the CLI version and adjusting copy within the addon. AP-4093 is resolved by setting the interactive option to false when we kick off the builds.

These changes were small and where I started before adding the additional remove/uninstall workflows. I kept moving ahead since this PR was still pretty small with the noted changes..

@thafryer thafryer added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Feb 6, 2024
@thafryer thafryer merged commit a41e8ca into main Feb 6, 2024
6 checks passed
@thafryer thafryer deleted the qa-fast-follows branch February 6, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants