-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA Fast Follows #172
QA Fast Follows #172
Conversation
95c7a87
to
d32d3a2
Compare
a7d5c46
to
639d120
Compare
639d120
to
debbf29
Compare
59362ef
to
4683387
Compare
f1610e4
to
4e18bec
Compare
4e18bec
to
577db81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code wise. I think the Panel
component is getting a bit messy now, perhaps there's some simple things we can do to clean it up a bit.
Are these two changes in the CLI? Are they part of this PR just via bumping the version? In general, it would be better to have multiple PRs if different things are happening, IMO. |
Yes! AP-4088, AP-4135, and AP-4189 are resolved by bumping the CLI version and adjusting copy within the addon. AP-4093 is resolved by setting the interactive option to false when we kick off the builds. These changes were small and where I started before adding the additional remove/uninstall workflows. I kept moving ahead since this PR was still pretty small with the noted changes.. |
9faa6f9
to
44b0cdc
Compare
36f4e50
to
9d48858
Compare
Fixes AP-4093, AP-4088, AP-4129, AP-4130, AP-4135, AP-4189
This PR seeks to resolve issues resulting from QA and feedback.
📦 Published PR as canary version:
1.0.5--canary.172.9d48858.0
✨ Test out this PR locally via: