Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent stories from targeting production API and upgrade GraphQL & MSW #135

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

ghengeveld
Copy link
Member

Overrides CHROMATIC_API_URL in Storybook to /api, to keep stories from talking to https://www.chromatic.com/api (the default API URL), whilst still allowing the live Visual Test addon to function normally.

Note that overriding CHROMATIC_BASE_URL didn't work, seemingly because it's already defined in vite.config.ts.

I also upgraded the msw, msw-storybook-addon and graphql dependencies.

Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghengeveld ghengeveld merged commit 82db5e6 into main Oct 20, 2023
@ghengeveld ghengeveld deleted the fix-graphql-mocking branch October 20, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants