Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sidebar status from build result #11

Merged
merged 19 commits into from
Jul 25, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 12, 2023

Use the new experimental_updateStatus API to set the sidebar status as build results come in.

image

It's not totally clear what statuses we should be setting (success or unknown for passing/accepted tests?). There are a lot of details to work through, but the wiring is there.


Note to run this right now you need to install the addon into a sandbox on the release/7.2 branch, like so:

  addons: [
    '@storybook/addon-links',
    '@storybook/addon-essentials',
    '@storybook/addon-onboarding',
    '@storybook/addon-interactions',
    {
      name: '/Users/tom/GitHub/chromaui/addon-visual-tests/dist/index.js', // or similar
      options: {
        projectId: '64acdc2151cdda2cb8b7eaaf',
        projectToken: 'chpt_4c07aba6aed67ce',
      },
    },
  ],
📦 Published PR as canary version: 0.0.6--canary.11.bd86cca.0

✨ Test out this PR locally via:

npm install @chromaui/[email protected]
# or 
yarn add @chromaui/[email protected]

@tmeasday tmeasday requested review from ghengeveld and ndelangen July 12, 2023 13:55
@linear
Copy link

linear bot commented Jul 12, 2023

tmeasday added 3 commits July 24, 2023 20:04
tsup seems to have a bug where it cleans both but only builds the one that changed
@tmeasday
Copy link
Member Author

I moved the memoization to the use effect, can you take a look @ndelangen?

@tmeasday tmeasday merged commit 6952cc7 into main Jul 25, 2023
@tmeasday tmeasday deleted the tom/ap-3340-set-sidebar-status-from-build branch July 25, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants