generated from storybookjs/addon-kit
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set sidebar status from build result #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar-status-from-build
ndelangen
reviewed
Jul 24, 2023
ndelangen
reviewed
Jul 24, 2023
ndelangen
reviewed
Jul 24, 2023
ndelangen
reviewed
Jul 24, 2023
ndelangen
reviewed
Jul 24, 2023
tsup seems to have a bug where it cleans both but only builds the one that changed
I moved the memoization to the use effect, can you take a look @ndelangen? |
ndelangen
reviewed
Jul 24, 2023
ndelangen
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
experimental_updateStatus
API to set the sidebar status as build results come in.It's not totally clear what statuses we should be setting (
success
orunknown
for passing/accepted tests?). There are a lot of details to work through, but the wiring is there.Note to run this right now you need to install the addon into a sandbox on the release/7.2 branch, like so:
📦 Published PR as canary version:
0.0.6--canary.11.bd86cca.0
✨ Test out this PR locally via: