Retrieve signed captureImage / diffImage URLs
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
requested review from
tmeasday and
weeksling
and removed request for
tmeasday
AP-3479 Snapshot images fail with 401 due to privacy settings (Safari)
After creating a new branch, applying some changes to a random component, committing those changes, and running the tests the addon fails to show the updated snapshot with the incoming change in the Safari browser. vt-addon-no-preview-safari.png Checking the dev tools It shows a 401 error, however copying and pasting the URL in a new Safari window loads the URL without any issues. vt-addon-no-preview-safari-dev-tools.png See the following Slack conversation for context. Update: Turning OFF "prevent cross site tracking" 'fixes' the issue: |
ghengeveld
deleted the
ghengeveld/ap-3479-snapshot-images-fail-with-401-due-to-privacy-settings-safari
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/chromaui/chromatic/pull/7731
📦 Published PR as canary version:
0.0.78--canary.108.9cd47c7.0✨ Test out this PR locally via: