Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] add distributed implementation for database deletion #3460

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[ENH] add distributed implementation for database deletion #3460

merged 1 commit into from
Jan 14, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jan 9, 2025 •
edited
Loading

Description of changes

Adds implementation for database deletion API to distributed Chroma.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Added a new Go test. Mostly tested with existing Python tests.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

@codetheweb codetheweb mentioned this pull request Jan 9, 2025
Merged
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@codetheweb Graphite App
Copy link
Contributor Author

codetheweb commented Jan 9, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codetheweb codetheweb changed the title Add distributed impl [ENH] add distributed implementation for database deletion Jan 9, 2025
@codetheweb codetheweb marked this pull request as ready for review January 9, 2025 22:05
@codetheweb codetheweb requested a review from rohitcpbot January 9, 2025 22:05
@codetheweb codetheweb force-pushed the feat-delete-database-single-node branch from 8e3c1ca to 9c8302f Compare January 9, 2025 23:10
@codetheweb codetheweb force-pushed the feat-delete-database-distributed branch from 66f9a9e to 1c7f888 Compare January 9, 2025 23:10
@codetheweb codetheweb force-pushed the feat-delete-database-single-node branch 2 times, most recently from adc995d to 1b4c82b Compare January 10, 2025 00:40
@codetheweb codetheweb force-pushed the feat-delete-database-distributed branch from 1c7f888 to 3e78b27 Compare January 10, 2025 00:40
@codetheweb codetheweb force-pushed the feat-delete-database-single-node branch from 1b4c82b to edd88bf Compare January 13, 2025 17:58
@codetheweb codetheweb force-pushed the feat-delete-database-distributed branch 2 times, most recently from aaa990a to 9b9e736 Compare January 13, 2025 18:00
@codetheweb codetheweb requested a review from rohitcpbot January 13, 2025 18:00
rohitcpbot
rohitcpbot approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@rohitcpbot rohitcpbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codetheweb codetheweb force-pushed the feat-delete-database-single-node branch from edd88bf to b3dab70 Compare January 13, 2025 23:07
@codetheweb codetheweb force-pushed the feat-delete-database-distributed branch from 9b9e736 to 2039415 Compare January 13, 2025 23:07
@codetheweb Graphite App
Copy link
Contributor Author

codetheweb commented Jan 14, 2025 •
edited
Loading

Merge activity

  • Jan 13, 7:00 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 13, 7:06 PM EST: Graphite couldn't merge this pull request because a downstack PR [ENH]: add method to delete database (single-node) #3457 failed to merge.
  • Jan 13, 7:43 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 13, 7:46 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 13, 7:47 PM EST: A user merged this pull request with Graphite.

@codetheweb codetheweb changed the base branch from feat-delete-database-single-node to graphite-base/3460 January 14, 2025 00:43
@codetheweb codetheweb changed the base branch from graphite-base/3460 to main January 14, 2025 00:44
@codetheweb codetheweb force-pushed the feat-delete-database-distributed branch from 2039415 to ea0ac3a Compare January 14, 2025 00:45
@codetheweb codetheweb merged commit 9ee24fd into main Jan 14, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitcpbot rohitcpbot rohitcpbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codetheweb @rohitcpbot