Suggested changes after review #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map to the correct FEDAUTHLIB_MSAL value Add functional tests for connection options Other minor adjustments
christothes
approved these changes
May 15, 2023
| @@ -2191,7 +2183,7 @@ public static void ChangePassword(string connectionString, string newPassword) | |||
| throw ADP.InvalidArgumentLength(nameof(newPassword), TdsEnums.MAXLEN_NEWPASSWORD); | |||
| } | |||
|
|
|||
| SqlConnectionPoolKey key = new SqlConnectionPoolKey(connectionString, credential: null, accessToken: null); | |||
| SqlConnectionPoolKey key = new SqlConnectionPoolKey(connectionString, credential: null, accessToken: null, accessTokenCallback: null); | |||
There was a problem hiding this comment.
Should we just make the argument required?
There was a problem hiding this comment.
I started to do that, but then I would have had to move the new parameter before the optional ones and then update more code references. In the interest of time, I left it optional. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow credential with callback and pass to the callback, if available
Don't allow Authentication option with callback
Map to the correct FEDAUTHLIB_MSAL value
Add functional tests for connection options
Ensure callback is correctly set on the pool key in all cases
Other minor adjustments