Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7 basic support #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yjiq150
Copy link

@yjiq150 yjiq150 commented Oct 21, 2017

Hi,

I appreciate your spidermonkey extension for PHP. I converted it for PHP7.2 in order to use it on my project with PHP7.x projects.

Currently every other basic functions are working very well on my general tests except the fact that you can't register closures from PHP to JS (It was not common use case for me so I didn't fix it yet).

[Summary]

  • Added few more basic test cases for the better test coverage.
  • 8 test case successes out of 12 in PHP 7.2
  • 6 test case successes out of 12 in PHP 7.1.x (I'm not sure but it seems that there were some issues related to zend_call_function in PHP 7.1.x)
  • Rest of the test cases are failing because registerFunction with closure is not currently working (left as todo)
  • Creating JS context & running Javascript is working well without memory leaks.

Please let me know if you find any errors or have any suggestions.

Thank you.
YoungJae

- Test case successes [8/12]
- registerFunction with closure is not currently working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant