Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I appreciate your spidermonkey extension for PHP. I converted it for PHP7.2 in order to use it on my project with PHP7.x projects.
Currently every other basic functions are working very well on my general tests except the fact that you can't register closures from PHP to JS (It was not common use case for me so I didn't fix it yet).
[Summary]
Please let me know if you find any errors or have any suggestions.
Thank you.
YoungJae