properly shell escape backslash, fixes #180 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate of #179?! /cc @christoomey |
|
Please add it to the README also (see #179 (comment)), then I can merge it, too. |
|
Thanks! |
christoomey
added a commit
that referenced
this pull request
Jul 7, 2017
Why --- #181 was introduced to fix an issues with the TPM install script not running cleanly. This was due to the `C-\` key binding not being properly escaped in the final line of the script. In the process of fixing this in #181, it looks like we took it a bit overboard and escaped _all_ `C-\` sequences. In the end, the others should not be escaped, so this was causing issues for users not configuring via TPM script. This change ----------- This change reverts all of the `C-\` escaping outside of the TPM script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.