Use smaller of response size and size in OD #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some devices use simplified logic for sending SDO response. They send an expedited 4 byte response for all sizes up to U32/I32. Unpacking code expects data size to exactly match the size in the object dictionary. Therefore use the smaller of the size for the variable in the OD and the actual response size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices use simplified logic for sending SDO response. They send an expedited 4 byte response for all sizes up to U32/I32. Unpacking code expects data size to exactly match the size in the object dictionary. Therefore use the smaller of the size for the variable in the OD and the actual response size.
I have seen this behaviour from two different types of devices, so it is not an isolated problem with one device type.