Fix aside menu

[KamiKillertO]

There's currently an issue with the aside menu button in the live demo app.

When we click on it, we are redirected to the documentation home page.
With this fix the aside menu button will now works as expected, when clicking on it it will open the side menu

I've also added a focus trap when the menu is opened

[lukemelia]

Hi @KamiKillertO Thanks for working on this. It looks like linting is failing on this PR. Can you fix that?

[KamiKillertO]

Sorry for that 😅

[KamiKillertO]

@lukemelia Done 👍

[bertdeblock]

Seems there's still a conflict. Probably because I merged #836, sorry for that. Looks good to go otherwise!

[bertdeblock]

We're running into embroider-build/embroider#1175 because of the ember-focus-trap addition. This isn't an issue with ember-freestyle itself, but just wanted to point out that this change might break people's Embroider based builds.

[lukemelia]

@bertdeblock What is the ideal resolution from your perspective?

[bertdeblock]

Other than fixing embroider-build/embroider#1175, I'm not sure to be honest.
The current workaround seems to be for the host app to install ember-focus-trap as well.
We could create an issue in ember-freestyle explaining this or even have this documented in the README or something until the bug is fixed. The only downside I guess is, we recommend to exclude ember-freestyle for production builds. If the host app itself doesn't use ember-focus-trap they end up with unused code in production builds unless they exclude ember-focus-trap manually themselves.

[bertdeblock]

FYI, embroider-build/embroider#1278 should fix this issue for us.