feat: logging level configuration #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bot is now supports setting minimum logging level that will be printed to console.
Use
BINANCE_LOG_LEVELenv variable, value passed to underlyingbunyanlog lib.Log levels pretty well described on bunyan page
Related Issue
#262 - will help to reduce CPU overhead
Motivation and Context
Reduce extensive amount of logs firing due to hardcoded
TRACElevel.Users are now free to set desired log level in order to reduce CPU and I/O overhead which is critical on tiny machines.
For the reason of backward compatibility default log level will be TRACE if not configured explicitly.
How Has This Been Tested?
Tested by enabling/disabling
BINANCE_LOG_LEVELenv variable indocker-compose.rpi.yml.Screenshots (if appropriate):