⬆️ Support nbdime v4 (drop <4 support) #62
Conversation
amotl
force-pushed
the
update-to-nbdime4
branch
from
b4c97b5 to
ad66b31
Compare
chrisjsewell
changed the title
| @@ -41,6 +41,7 @@ | |||
| "_pytest": ("https://doc.pytest.org/en/latest/", None), | |||
| # "PIL": ("http://pillow.readthedocs.org/en/latest/", None), | |||
| "nbclient": ("https://nbclient.readthedocs.io/en/latest/", None), | |||
| "nbdime": ("https://nbdime.readthedocs.io/en/latest/", None), | |||
There was a problem hiding this comment.
but now you should be able to remove the nbdime items in nitpick_ignore 😅
There was a problem hiding this comment.
Thanks. I just tried, but it doesn't work: Same error from Sphinx as before.
There was a problem hiding this comment.
Also tried adding ("py:class", "DiffConfig"): ("py:class", "nbdime.diffing.config.DiffConfig") to intersphinx_aliases, but it does not make any difference either.
pyproject.toml
Outdated
| @@ -31,7 +31,7 @@ dependencies = [ | |||
| "importlib-metadata~=6.0;python_version<'3.10'", | |||
| "importlib-resources~=5.0;python_version<'3.9'", | |||
| "nbclient~=0.5.10", | |||
| "nbdime", | |||
| "nbdime<5,>=4", | |||
There was a problem hiding this comment.
| "nbdime<5,>=4", | |
| "nbdime>=4", |
actually I think remove the upper-pinning, because otherwise if/when v5 comes out, pip could start pulling in older versions of this package (since they have no pinning)
There was a problem hiding this comment.
I will be happy to follow your suggestion.
However, may I ask if that isn't a good thing for stability reasons that only pytest-notebook has the authority to define compatible versions of dependencies? On the other hand, I know that is usual practice not to introduce too many pinnings on software which is actually a library, and rather make it compatible with different versions of dependency packages, in order not to trip dependent software too much. pytest-notebook may qualify as such a package, right?
From a naive perspective, without the upper-pinning, users may run into the same situation we had with the leap to version 4 when version 5 will be published?
There was a problem hiding this comment.
I will be happy to follow your suggestion.
Fixed.
There was a problem hiding this comment.
its always a tricky subject, but for now I think I'll stick with no pinning and look at that later
amotl
force-pushed
the
update-to-nbdime4
branch
from
49dfcfe to
84f7166
Compare
chrisjsewell
changed the title
About