Simple change to implement Default on map #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can’t imagine why RawMap implements Default and Map doesn’t. Given the implementation of Default for RawMap, mightn’t it just as well be put in the impl_common_methods macro? It seems to work. |
|
Think that makes sense to me, is this what you meant? |
|
Thanks for that. I put it in with a handful of commits I had made locally but apparently not pushed. I must make a release. |
|
When on crates.io? |
vi
added a commit
to vi/websocat
that referenced
this pull request
Dec 5, 2019
chris-morgan/anymap#37 chris-morgan/anymap#30 The needed commit happened 2 years ago: chris-morgan/anymap@0850f5e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default trait is implemented for RawMap but not on Map, add an implementation that creates an empty map as in RawMap.