Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add website to DESCRIPTION #7

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Add website to DESCRIPTION #7

merged 4 commits into from
Feb 12, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Feb 12, 2024

The goal is to help with discovery and linking see: https://blog.r-hub.io/2019/12/10/urls/

I made a few additional edits.

For example, README.Rmd, _pkgdown.yml and alookr.Rproj should be in the repository, so deleted them from .gitignore.

Added backticks around function names in NEWS.md so they show as code, and this helps linking as well.

Renamed the logo file to logo.png because that is what pkgdown recognizes, and added favicons so that the logo shows in the page.

On your side, I would suggest to run devtools::build_site(). so that it receives the updates made in the package

Happy to answer questions!

Cheers

@choonghyunryu choonghyunryu merged commit d92498a into choonghyunryu:master Feb 12, 2024
@choonghyunryu
Copy link
Owner

choonghyunryu commented Feb 12, 2024

@olivroy,

Thank you so much.
Your PR has been a great help to alookr.

Cheers

@choonghyunryu choonghyunryu added the documentation Improvements or additions to documentation label Feb 12, 2024
@choonghyunryu choonghyunryu self-requested a review February 12, 2024 22:35
@olivroy olivroy deleted the tweaks branch February 12, 2024 22:43
@olivroy olivroy removed their assignment Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants