fix creating record file when not required #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chomosuke
requested changes
Nov 25, 2024
lua/typst-preview/fetch.lua
Outdated
| for _, bin in pairs(M.bins_to_fetch()) do | ||
| record:write(bin.url .. '\n') | ||
| if config.opts.dependencies_bin[bin.name] ~= nil then |
There was a problem hiding this comment.
Wouldn't this mark record_required as false when one of the dependencies_bin doesn't need to be downloaded but the other one does?
There was a problem hiding this comment.
ah true, my bad
lua/typst-preview/fetch.lua
Outdated
| if record == nil then | ||
| error("Can't open record file!: " .. err) | ||
| end | ||
| for _, bin in pairs(M.bins_to_fetch()) do |
There was a problem hiding this comment.
Perhaps it's best to only write the bin that are not in dependencies_bin into record file.
There was a problem hiding this comment.
yes, that would be better
chomosuke
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #72