-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Port #34
Custom Port #34
Conversation
Hello there, thanks for this PR. I'll be happy to merge this PR if you add the |
Sure, I will work on that |
Sorry for the delay. I implemented the error handling and added documention (in README.md and typst-preview.nvim.txt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the delay as well, I did not notice that you've completed this PR.
I will be happy to merge this PR if you can somehow handle the error of if the port is already in use by another process. I believe you might need to inspect the output by the typst-preview binary to achieve this.
Thank you
Hi, I have updated the codebase. It will now detect the "AddrInUse" error from tinymist. To handle the error, the code will attempt to use the next port (e.g. try 8001 instead of 8000). I have also updated the docs and README. |
Hi, can we maybe not try "port +1" by default or at least have an option to disable it? Instead can we return an error so that user can handle the error by themselves if they prefer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except some early return that I subjectively did not like.
@LEXUGE Please open a new issue requesting this. This PR has been there for a while and i'd like to merge it instead of requesting more changes. |
And thank you for excellent work :>. |
Passing
--static-file-host 127.0.0.1:0
as arguments to the typst preview binary will start the preview local server on a random port. This PR adds an option to the config that allows a user-specified port instead of a random one.resolves #33