Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased buffer size for websocat #20

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Increased buffer size for websocat #20

merged 1 commit into from
Feb 25, 2024

Conversation

AxiomOfChoices
Copy link
Contributor

Fixes #19, this just hard codes a new limit but it might be reasonable to add this as a configuration option, I am not sure.

chomosuke
chomosuke approved these changes Feb 25, 2024
View reviewed changes
Copy link
Owner

@chomosuke chomosuke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We could look into creating this as a config option if this issue appear again in the future. For now I think it's unlikely that anyone would care about 10MB of memory or write a 10MB typst document.

And thank you for spotting this :).

@chomosuke chomosuke merged commit a5b7192 into chomosuke:master Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chomosuke chomosuke chomosuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview stops updating on typing for large enough files
2 participants
@AxiomOfChoices @chomosuke