Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #435 #534

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Fix for issue #435 #534

merged 4 commits into from
Dec 16, 2021

Conversation

mjw99
Copy link
Collaborator

@mjw99 mjw99 commented Dec 9, 2021 •
edited
Loading

Description

Fixes TestAbsoluteAlchemicalFactory.test_overlap NaNs

Todos

  • Implement feature / fix bug
  • Add tests
  • Update documentation as needed
  • Update changelogNotable points that this PR has either accomplished or will accomplish.

Status

  • Ready to go

@mikemhenry mikemhenry self-requested a review December 13, 2021 19:01
mikemhenry
mikemhenry approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@mikemhenry mikemhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mikemhenry mikemhenry mentioned this pull request Dec 13, 2021
Merged
5 tasks
@mikemhenry mikemhenry enabled auto-merge (squash) December 13, 2021 20:02
@mikemhenry mikemhenry disabled auto-merge December 13, 2021 20:02
@mikemhenry mikemhenry enabled auto-merge (squash) December 14, 2021 00:28
@mikemhenry mikemhenry disabled auto-merge December 14, 2021 21:59
jchodera
jchodera approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@jchodera jchodera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This doesn't appear to extend CI time, so it should be good to merge!

@mjw99
Copy link
Collaborator Author

mjw99 commented Dec 16, 2021

Is there anything more that I need to do/provide for this PR?

@mikemhenry
Copy link
Contributor

No it is good to merge! 🎉 thanks!

@mikemhenry mikemhenry merged commit 456af23 into choderalab:master Dec 16, 2021
@jchodera
Copy link
Member

Thanks!

@mikemhenry mikemhenry mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchodera jchodera jchodera approved these changes

@mikemhenry mikemhenry mikemhenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjw99 @mikemhenry @jchodera