-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring multistate samplers into openmmtools #398
Conversation
Porting multistates from yank to openmmtools(multistate branch)
I've enabled sphinx builds for this branch, but it looks like they are failing:
Looks like we need to add |
Will add that now, missed it because there's no docs/environment.yaml in yank |
Will try figure out why the python 3.7 travis build is seg faulting, but I can't reproduce it locally |
That may be a known problem, see #192 . I've never been able to figure out a work-around (beside restarting the Travis tests). It seems more of a Travis+SWIG+nosetests problem than a real issue. |
You don't think switching to |
Happy to try switching over. I think the tests that use yield will need to be updated |
Possibly, I'm not sure. I'm still getting familiar with |
Maybe we can do that switch as part of a larger overhaul to conform to the latest cookiecutter structure, after @andrrizzi has more time to get familiar with it? |
Multistate sampler docs are being built and pushed to this branch of readthedocs. You can see the API docs here. |
This is almost ready to be merged, @andrrizzi. I'm just solving some problems with SAMS tests that use the currently-unsupported non-global jumps, but I might just change that to global jump only and punt the rest of the local jump to later. |
Correction: The failing tests are with SAMS and global jump, and started when we upgraded the NetCDF libraries to a version that uses masked arrays by default. However, I think this may have revealed a bug in the old SAMS analysis implementation. Will be important to see if we can fix this. |
I think I've sorted this. If tests pass, this should be ready to merge. |
Yay! Travis tests pass now. Windows tests fail because |
The docs build on readthedocs now! |
This PR brings multistate samplers and the FIRE minimizer from YANK into
openmmtools
.