Exception if no sources #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the link from "Community tag" to "Up for Grabs"
(maint) README.md - Update "Community tag" link
* stable: (maint) fixing tests for appveyor / teamcity
* stable: (maint) test fix redeaux
* stable: (maint) test fix part tres
* stable: (maint) no really, fix the tests
* stable: (maint) Remove unused variable (maint) cleaning up warnings (build) update uc / ilmerge (GH-480) '/All' must be the last arg to dism.exe.
* stable: (GH-507)(specs) fixup spelling
* stable: (maint) formatting (spec) Ensure MockLogger is setup first in test suite (specs) Allow for nupkgs to finish copying (specs) use deep copy for config (GH-516) Fix: Log.InitializeWith doesn't clear cached loggers (GH-445) Only fail scripts on non-zero exit code (GH-510) allow silentargs in template
* stable: (doc) update Changelog (GH-8) Use Custom PowerShell Host (GH-8) Configuration for PowerShell Host (GH-8) Implement Custom PowerShell Host (GH-8) Add System.Management.Automation binary (GH-8) Convert to SecureString (GH-8) ReadKey Timeout (GH-8) Run commands with timeout (maint) add messages to package installers (GH-8) ReadLine Timeout (GH-445) Scenario docs update (GH-520) Fix: Debug/Verbose messages not logged
* stable: (doc) Add Windows versions to requirements
* stable: (GH-534) Update ChocolateyUninstallTemplate.cs
Previously if no sources were available during installation of a package, installation would fail with an Exception. This fix will make the choco client check the source list to make sure it is not null before attempting to install a package.
|
Hmm, I seem to have done something strange here - it should only be my commit, I'm sorry @ferventcoder. |
|
Superseded by #547. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if no sources were available during installation of a
package, installation would fail with an Exception. This fix will make
the choco client check the source list to make sure it is not null
before attempting to install a package.
As per my discussion with @ferventcoder this fixes #490.
The exception itself occurs at
\src\chocolatey\infrastructure.app\services\NugetService.cs:313when checking the source list contains an extension without confirming there is something in the source list first. I've added in a check before showing the licenses to confirm that there is sources defined.