GH-303 Install-ChocolateyPath Expands Variables in PATH, Overwriting #373
+27
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately due to where this is, it's not easily testable on OS X. |
| $option = [Microsoft.Win32.RegistryValueOptions]::None | ||
| } | ||
|
|
||
| $value = $reg.GetValue('Path', $null, $option) |
There was a problem hiding this comment.
Good catch, thanks. Will update PR.
There was a problem hiding this comment.
I noticed this hasn't yet been updated.
There was a problem hiding this comment.
@mnadel Take a look here, this PR hasn't been updated.
|
Thanks, I suspected as much.
|
…erwriting Preexisting Variables When adding a new element to PATH, Install-ChocolateyPath reads PATH (wh ich contains expanded variables), appends the new element, and then writes the value back to PATH. This results in PATH having its variables overwritten with its values. Instead of reading $env:PATH to find the current path, read it from the registry, which will retain the PATH's original variables.
mnadel
force-pushed
the
feature/install-path-retain-vars
branch
from
a5245bc to
bafe091
Compare
| function Get-EnvironmentVariable([string] $Name, [System.EnvironmentVariableTarget] $Scope, [bool] $PreserveVariables = $False) { | ||
| if ($pathType -eq [System.EnvironmentVariableTarget]::Machine) { | ||
| $reg = [Microsoft.Win32.Registry]::Machine.OpenSubKey("Environment", $true) | ||
| } else { |
There was a problem hiding this comment.
This does not handle the third possible EnvironmentVariableTarget, Process (which has nothing to do with the registry).
|
Superseded by #600. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested ... thoughts on how to test this on a Mac?
Closes #303