Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#3591) Remove no7zip build tasks #3609

Merged
merged 1 commit into from
Jan 28, 2025
Merged

(#3591) Remove no7zip build tasks #3609

merged 1 commit into from
Jan 28, 2025

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Jan 28, 2025

Description Of Changes

This commit removes the no longer required no7zip build tasks, and also the associated sln and csproj entries.

Motivation and Context

Previously, it was necessary to build a version of choco.exe that didn't include the 7zip binaries, however, this version of Chocolatey CLI is no longer required.

To simplify the overall build process, and also the release steps required, the decision was taken to completely remove the no7zip build.

Testing

  • Full local build completed using .\build.bat.
  • Verify no no7zip artifacts are created
  • Verify that normal artifacts from build are created, i.e. chocolatey, chocolatey.lib, chocolatey.powershell nupkg's
  • CI builds will be completed as a result of this PR.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build changes

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #3591

@gep13
(chocolatey#3591) Remove no7zip build tasks
8e3baf9 
This commit removes the no longer required no7zip build tasks, and also
the associated sln and csproj entries.

Previously, it was necessary to build a version of choco.exe that didn't
include the 7zip binaries, however, this version of Chocolatey CLI is no
longer required.

To simplify the overall build process, and also the release steps
required, the decision was taken to completely remove the no7zip build.
@gep13 gep13 requested review from corbob and vexx32 January 28, 2025 11:23
corbob
corbob approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can confirm it builds correctly on my developer VM.

@corbob corbob merged commit c870ae6 into chocolatey:develop Jan 28, 2025
5 checks passed
@gep13 gep13 deleted the issue-3591 branch January 29, 2025 11:03
corbob added a commit to corbob/choco that referenced this pull request Jan 31, 2025
@corbob
(chocolatey#3618) Ensure ILMerge can run
4495157 
Previously in chocolatey#3609 we removed the No7zip build configuration. This
build configuration set itself as a dependee of ILMerge, and a Dependent
of Build and Test. This resulted in the ILMerge task being dependent
upon Build and Test.

This commit sets the ILMerge task to be dependent upon both Build and
Test so that builds that target just the ILMerge can succeed.
@corbob corbob mentioned this pull request Jan 31, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corbob corbob corbob approved these changes

@vexx32 vexx32 Awaiting requested review from vexx32

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the no7ip build steps from overall Chocolatey CLI build process
2 participants
@gep13 @corbob