-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-121) Capture And Remove Files Related to Package Installation #270
Merged
ferventcoder
merged 18 commits into
chocolatey:stable
from
ferventcoder:ticket/stable/GH-121-file-snapshot
May 15, 2015
Merged
(GH-121) Capture And Remove Files Related to Package Installation #270
ferventcoder
merged 18 commits into
chocolatey:stable
from
ferventcoder:ticket/stable/GH-121-file-snapshot
May 15, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the package files classes and the package information file they will produce.
Add ability to read and save package file information.
Add the interaction to the package information service to read the files file and save to the files file.
Allow IFileSystem to read a file and return the file bytes as an array.
To compute hashes in files, add a hash provider that can determine hashes of files.
Capture the package hashes after everything, including the install script, has had a chance to run.
- Rename Md5HashProvider to CryptoHashProvider and provide enumeration for HashAlgorithm Crytpo providers. - Implement adapter for HashAlgorithm. - Update specs for CryptoHashProvider - Specs for FilesService
When the files that were installed during install are unchanged, they should be removed from the package directory. Any files that have changed should stick around.
To see messages coming from Nuget, prefix it with "[NuGet]" so that there is no confusion where the messages are coming from.
While adding scenarios it was discovered that the empty directories were not being removed, so the service will ensure those are removed upon removing a package with no changed files in it.
Results is actually a singular result, so the naming is off. Fix that to be appropriate.
The entire package checksum is not needed at this time so remove it.
When files have changed in a package, back those files up prior to upgrade.
Add fault tolerance around deleting the nupkg with an error. Add fault tolerance around deleting the rest of the files on the system.
ferventcoder
added a commit
that referenced
this pull request
May 15, 2015
…napshot (GH-121) Capture And Remove Files Related to Package Installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121