(#2078) Skip importing Chocolatey GUI Extension #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change results in the
to this:
when the Chocolatey GUI Licensed Extension is installed. |
pauby
approved these changes
Apr 16, 2021
The Chocolatey GUI Extension is a "special" extension in the sense that it isn't intended to work with Chocolatey directly, but it is shipped as a "normal" Chocolatey extension. We don't want to load the chocolateygui.licensed.dll into the choco.exe process, but rather leave it alone, and allow Chocolatey GUI to load it when required.
The file predominately uses spaces, so remove the tabs to makes things consistent.
|
@pauby thank you for the review. Going to get this merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chocolatey GUI Extension is a "special" extension in the sense that
it isn't intended to work with Chocolatey directly, but it is shipped as
a "normal" Chocolatey extension. We don't want to load the
chocolateygui.licensed.dll into the choco.exe process, but rather leave
it alone, and allow Chocolatey GUI to load it when required.
We are already skipping one existing folder when looking for extension
paths, so this has been extended to include the chocolateygui foler.
Fixes #2078