Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1998) Add authorization header to Get-WebFile #1999

Closed
wants to merge 3 commits into from
Closed

(#1998) Add authorization header to Get-WebFile #1999

wants to merge 3 commits into from

Conversation

steviecoaster
Copy link
Contributor

Fixes #1998

  • Reworks header manipulation to use $key instead of GetEnumerator() method

Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing I noticed on a re-read, everything else looks good! 👍

* Reworks headers to not use GetEnumerator() method, and appropriately
adds headers to `$options` hashtable.
'Cookie' {$req.CookieContainer.SetCookies($uri,$options.headers.$key)}
'Referer' {$req.Referer = $options.headers.$key}
'User-Agent' {$req.UserAgent = $options.headers.$key}
'Authorization' {$re.Autorization = $options.headers.$key}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental misspelling?

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2020

CLA assistant check
All committers have signed the CLA.

@gep13 gep13 changed the title Gh 1998 (#1998) Add authorization header to Get-WebFile Apr 18, 2021
@gep13
Copy link
Member

gep13 commented Apr 18, 2021

@steviecoaster this has been rebased and merged here: 5580558

I wasn't able to push this changes to your fork, as it looks like it has been deleted, but your commit has still been correctly attributed.

I will go ahead and close this PR, as it is no longer required.

@gep13 gep13 closed this Apr 18, 2021
@gep13
Copy link
Member

gep13 commented Apr 18, 2021

@steviecoaster thanks for your help in getting this fixed up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to use authorization headers in the Get-WebFile function
5 participants