-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1998) Add authorization header to Get-WebFile #1999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing I noticed on a re-read, everything else looks good! 👍
* Reworks headers to not use GetEnumerator() method, and appropriately adds headers to `$options` hashtable.
'Cookie' {$req.CookieContainer.SetCookies($uri,$options.headers.$key)} | ||
'Referer' {$req.Referer = $options.headers.$key} | ||
'User-Agent' {$req.UserAgent = $options.headers.$key} | ||
'Authorization' {$re.Autorization = $options.headers.$key} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accidental misspelling?
@steviecoaster this has been rebased and merged here: 5580558 I wasn't able to push this changes to your fork, as it looks like it has been deleted, but your commit has still been correctly attributed. I will go ahead and close this PR, as it is no longer required. |
@steviecoaster thanks for your help in getting this fixed up! |
Fixes #1998
GetEnumerator()
method