-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting Typos #148
Correcting Typos #148
Conversation
- Thanks to the ReSpeller Extension for Resharper
@@ -40,7 +40,7 @@ private static bool log_is_in_debug_mode() | |||
} | |||
|
|||
/// <summary> | |||
/// Tries an action the specified number of tries, warning on each failure and erroring on the last. | |||
/// Tries an action the specified number of tries, warning on each failure and raises error on the last attempt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha. I'm not sure if error can be used as a verb but I always have!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erroring
definitely didn't feel right to me :-)
Perhaps failure and raises an error on the last attempt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grrr, stupid phone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hee hee, I was wondering why you were repeating yourself 😸
This should be good to go, I'll test it later |
Cool, let me know if there are any other issues with this PR. |
@ferventcoder sorry, this should have really been done on my own fork, but I was half way through all the edits before I realised, and didn't want to lose all the changes, so thought I would create temp branch in this repo :-(
There were a few more changes than I thought there would be, so thought you would want to check them through before pulling them in.