Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting Typos #148

Merged
merged 1 commit into from
Mar 6, 2015
Merged

Correcting Typos #148

merged 1 commit into from
Mar 6, 2015

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Mar 4, 2015

@ferventcoder sorry, this should have really been done on my own fork, but I was half way through all the edits before I realised, and didn't want to lose all the changes, so thought I would create temp branch in this repo :-(

There were a few more changes than I thought there would be, so thought you would want to check them through before pulling them in.

- Thanks to the ReSpeller Extension for Resharper
@@ -40,7 +40,7 @@ private static bool log_is_in_debug_mode()
}

/// <summary>
/// Tries an action the specified number of tries, warning on each failure and erroring on the last.
/// Tries an action the specified number of tries, warning on each failure and raises error on the last attempt.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha. I'm not sure if error can be used as a verb but I always have!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erroring definitely didn't feel right to me :-)

Perhaps failure and raises an error on the last attempt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grrr, stupid phone

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hee hee, I was wondering why you were repeating yourself 😸

@ferventcoder
Copy link
Member

This should be good to go, I'll test it later

@gep13
Copy link
Member Author

gep13 commented Mar 5, 2015

Cool, let me know if there are any other issues with this PR.

ferventcoder added a commit that referenced this pull request Mar 6, 2015
@ferventcoder ferventcoder merged commit e8c5baf into stable Mar 6, 2015
@ferventcoder ferventcoder deleted the typo branch March 6, 2015 23:43
@ferventcoder ferventcoder added this to the 0.9.9.2 milestone Mar 6, 2015
ferventcoder added a commit that referenced this pull request Mar 7, 2015
gep13 pushed a commit to gep13/choco that referenced this pull request Mar 7, 2015
gep13 pushed a commit to gep13/choco that referenced this pull request Mar 23, 2015
gep13 pushed a commit to gep13/choco that referenced this pull request Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants