Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List output for other tools messed up in 0.9.9.9 (pipe separator missing) #450

Closed
crt opened this issue Oct 3, 2015 · 16 comments
Closed

List output for other tools messed up in 0.9.9.9 (pipe separator missing) #450

crt opened this issue Oct 3, 2015 · 16 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.9.9.10

Comments

@crt
Copy link

crt commented Oct 3, 2015

Hi All,

We are using Chocolatey with the official Puppet module on lots of Windows boxes. After Puppet updated Chocolatey to 0.9.9.9 version last night, all boxes are continuously installing each defined chocholatey packages in every half an our, which is the default Puppet running interval.

Please let me know if you need some logs, however we don't get any error messages, everything is working fine except this issue.

Thank you for your help,
Zoli

This was caused by a change in 5782a21#commitcomment-13577152 for #132.
@ferventcoder
Copy link
Member

And you are on the latest provider?

@ferventcoder
Copy link
Member

puppet module list

@ferventcoder
Copy link
Member

We'll def need logs and manifests - were you upgrading an existing choco installation?

@ferventcoder
Copy link
Member

@rismoney are you experiencing similar?

@ferventcoder
Copy link
Member

Nothing that I am aware of changed in choco list that would cause this, but software...

@rismoney
Copy link
Contributor

rismoney commented Oct 3, 2015

I haven't had a chance to do 0.9.9.9I can get to it really late tonight or Monday morning. Did output formatting change?

@ferventcoder
Copy link
Member

I don't believe so, otherwise I would have run it through a few more tests.

@crt
Copy link
Author

crt commented Oct 3, 2015

Hi Rob,

We used the 1.0.2 version, now I have just upgraded to the latest version (chocolatey-chocolatey (v1.1.2)), but the result is the same.

I have tried to attach our mini-module, the hiera config, and the chocolatey.log from the client host but it didn't allow me (Something went really wrong, and we can’t process that file). The files were renamed to .txt extensions, but no luck. How can I send you these files?

This is the output of the Puppet in every run:

2015-10-03 20:29:32 +0200 /Stage[main]/Ds-win::Choco/Package[silverlight]/ensure (notice): created
2015-10-03 20:29:48 +0200 /Stage[main]/Ds-win::Choco/Package[vlc]/ensure (notice): created
2015-10-03 20:30:04 +0200 /Stage[main]/Ds-win::Choco/Package[gimp]/ensure (notice): created
2015-10-03 20:30:20 +0200 /Stage[main]/Ds-win::Choco/Package[firefox]/ensure (notice): created
2015-10-03 20:30:53 +0200 /Stage[main]/Ds-win::Choco/Package[chocolatey]/ensure (notice): created
2015-10-03 20:31:05 +0200 /Stage[main]/Ds-win::Choco/Package[wget]/ensure (notice): created
2015-10-03 20:31:20 +0200 /Stage[main]/Ds-win::Choco/Package[adobereader]/ensure (notice): created
2015-10-03 20:31:37 +0200 /Stage[main]/Ds-win::Choco/Package[flashplayerplugin]/ensure (notice): created
2015-10-03 20:31:48 +0200 /Stage[main]/Ds-win::Choco/Package[javaruntime-preventasktoolbar]/ensure (notice): created
2015-10-03 20:32:00 +0200 /Stage[main]/Ds-win::Choco/Package[fciv]/ensure (notice): created
2015-10-03 20:32:16 +0200 /Stage[main]/Ds-win::Choco/Package[skype]/ensure (notice): created
2015-10-03 20:32:32 +0200 /Stage[main]/Ds-win::Choco/Package[javaruntime]/ensure (notice): created
2015-10-03 20:32:43 +0200 /Stage[main]/Ds-win::Choco/Package[putty.install]/ensure (notice): created
2015-10-03 20:32:55 +0200 /Stage[main]/Ds-win::Choco/Package[winscp.install]/ensure (notice): created
2015-10-03 20:33:11 +0200 /Stage[main]/Ds-win::Choco/Package[7zip.install]/ensure (notice): created
2015-10-03 20:33:24 +0200 /Stage[main]/Ds-win::Choco/Package[curl]/ensure (notice): created
2015-10-03 20:33:57 +0200 /Stage[main]/Ds-win::Choco/Package[opera]/ensure (notice): created
2015-10-03 20:34:45 +0200 /Stage[main]/Ds-win::Choco/Package[sudo]/ensure (notice): created
2015-10-03 20:35:24 +0200 /Stage[main]/Ds-win::Choco/Package[nmap]/ensure (notice): created
2015-10-03 20:35:53 +0200 /Stage[main]/Ds-win::Choco/Package[word.viewer]/ensure (notice): created
2015-10-03 20:35:53 +0200 Puppet (notice): Finished catalog run in 408.11 seconds

@ferventcoder
Copy link
Member

Paste the content into a gist and link the gist here. Gist.github.com

@crt
Copy link
Author

crt commented Oct 3, 2015

These are the files:

https://gist.github.com/crt/09e6f37fc04698ce6e7a

Thanks,
Zoli

@ferventcoder
Copy link
Member

I found the issue. Ugh 5782a21#commitcomment-13577152

@ferventcoder ferventcoder modified the milestone: 0.9.10 Oct 3, 2015
@ferventcoder ferventcoder changed the title Puppet-Chocolatey issue after updating to 0.9.9.9 List output for config managers messed up in 0.9.9.9 Oct 3, 2015
@ferventcoder
Copy link
Member

@crt I'm working on a fix for this now. I would suggest holding off on a wider deployment. If you have already did a wide deployment, this will be fixed very soon.

@ferventcoder ferventcoder modified the milestones: 0.9.10, 0.9.9.10 Oct 3, 2015
@ferventcoder
Copy link
Member

@crt The good news is that the list issues will not happen again. Bumped up integration specs coverage on this, so appveyor will catch it the next time.

ferventcoder added a commit that referenced this issue Oct 3, 2015
@ferventcoder
(GH-450) Restore pipe separator for limited list output
38537c3 
When other tools use choco to determine whether a package is installed
they use `choco list -lo -r`. The -r is to limit output, show only the
package information. At one point the output separated information with
pipes, unlike the normal output. However when commit 5782a21 was
introduced, it accidentally removed this very important distinction.
Correct this to again us pipes.

Also add integration spec scenarios to ensure this is not subject to
happen again.
ferventcoder added a commit that referenced this issue Oct 3, 2015
@ferventcoder
Merge branch 'stable'
21789bc 
* stable:
  (GH-450) Restore pipe separator for limited list output
  (GH-447) Fix escaped chars in new help message
@ferventcoder ferventcoder self-assigned this Oct 3, 2015
@crt
Copy link
Author

crt commented Oct 3, 2015

Hi Rob,

Thank you for your help and quickness. Unfortunately, all of our hosts got the latest version, so I have to wait for next one.

Thanks once again,
Zoli

@ferventcoder ferventcoder changed the title List output for config managers messed up in 0.9.9.9 List output for other tools messed up in 0.9.9.9 (pipe separator missing) Oct 3, 2015
@ferventcoder
Copy link
Member

The good news is that next version is now available

@RichiCoder1
Copy link
Contributor

insert ninja here

ferventcoder added a commit that referenced this issue Oct 6, 2015
@ferventcoder
(GH-450)(specs) More integration specs for list
a330a00 
Add the following Scenarios:
- when searching all available packages
- when searching for a particular package
- when searching packages with no filter
- when searching packages with verbose
ferventcoder added a commit that referenced this issue Oct 6, 2015
@ferventcoder
Merge branch 'stable'
b9098ab 
* stable:
  (version) 0.9.9.11
  (doc) release notes for 0.9.9.11
  (GH-452) Fix broken pin command
  (GH-450)(specs) More integration specs for list
  (maint) Search methods MockLogger
  (maint) print choco version when no args

# Conflicts:
#	.uppercut
#	CHANGELOG.md
@ferventcoder ferventcoder mentioned this issue Oct 24, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.9.9.10
Development

No branches or pull requests
5 participants
@ferventcoder @crt @gep13 @rismoney @RichiCoder1